Conversation
|
|
Contributor
Author
|
Link to issue #3968 |
Collaborator
|
Thanks, if you could also update the |
cpsievert
reviewed
Jun 16, 2025
package.json
Outdated
| "@types/datatables.net": "^1.10.19", | ||
| "@types/ion-rangeslider": "2.3.0", | ||
| "@types/jquery": "3.5.14", | ||
| "@types/jquery": "3.5.29", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "@types/jquery": "3.5.29", | |
| "@types/jquery": "3.5.32", |
Collaborator
|
Thanks! |
schloerke
added a commit
that referenced
this pull request
Jul 6, 2025
* main: (32 commits) Revert the addition of spacing between `icon` and `label` in `actionButton()` (#4248) Restrict `icon`/`label` separator spacing to `actionButton()` (#4247) Fix front-end action button label updating logic (#4242) Update news Properly handle undefined value for input subscribe callback (#4243) Start new version (#4241) v1.11.0 release candidate (#4232) Follow up to #3996: fix front-end checkbox label updating logic (#4238) feat(InputBinding): subscribe callback now supports event priority (#4211) Follow up to #3996 when label is unspecified (i.e., NULL), don't include it in the message (#4237) Run routine (#4234) chore: #4175 update jquery-ui to 1.14.1 (#4205) Update jQuery to 3.7.1 (#3969) Fix 404 in example 08_html (shiny.min.css) (#4221) Follow up to #3870: fix location of news item (#4233) Bugfix for error found in tests (#3870) Allow update input labels with HTML (#3996) Adds mirai to documentation (#4230) family->given for R Core authorship (#4222) fix(renderPlot): get interactive plotting working with ggplot2 v4.0 (#4228) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the steps as outlined in tools/updatejQuery.R to update jQuery to 3.7.1 (current latest stable) and jQuery Types to 3.5.29 (current latest stable). This ran without problems.
To be sure, I verified that:
inst/www/sharedfolders (jquery.js,jquery.min.js,jquery.min.js.map)yarn.lockand 'package.json'.file were updated accordinglyNote: devtools::check() did give me an (unrelated) error in the tabPanel test. But this test also occurs in main/ at the moment. Looking at the diff, it appears to be that the generated html wraps a body tag around the code that is to be asserted.